Skip to content

Avoid owner and group lookups in WASI filestat #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andreaTP merged 1 commit into from
Nov 2, 2026
Merged

Avoid owner and group lookups in WASI filestat #266

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions wasi/src/main/java/run/endive/wasi/WasiPreview1.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,11 @@
*/
@HostModule("wasi_snapshot_preview1")
public final class WasiPreview1 implements Closeable {
// Avoid unix:*: owner and group attributes trigger name lookups.
private static final String FILESTAT_ATTRIBUTES =
"unix:dev,ino,nlink,size,lastAccessTime,lastModifiedTime,ctime,"
+ "isSymbolicLink,isDirectory,isRegularFile";

private final Logger logger;
private final Random random;
private final Clock clock;
Expand Down Expand Up @@ -461,7 +466,7 @@ public int fdFilestatGet(Memory memory, int fd, int buf) {

Map<String, Object> attributes;
try {
attributes = Files.readAttributes(path, "unix:*");
attributes = Files.readAttributes(path, FILESTAT_ATTRIBUTES);
} catch (UnsupportedOperationException e) {
return wasiResult(WasiErrno.ENOTSUP);
} catch (IOException e) {
Expand Down Expand Up @@ -773,7 +778,7 @@ public int fdReaddir(

Map<String, Object> attributes;
try {
attributes = Files.readAttributes(entryPath, "unix:*");
attributes = Files.readAttributes(entryPath, FILESTAT_ATTRIBUTES);
} catch (UnsupportedOperationException e) {
return wasiResult(WasiErrno.ENOTSUP);
} catch (NoSuchFileException e) {
Expand Down Expand Up @@ -1029,7 +1034,7 @@ public int pathFilestatGet(
path = resolved.resolved();
}
}
attributes = Files.readAttributes(path, "unix:*", linkOptions);
attributes = Files.readAttributes(path, FILESTAT_ATTRIBUTES, linkOptions);
} catch (UnsupportedOperationException e) {
return wasiResult(WasiErrno.ENOTSUP);
} catch (NoSuchFileException e) {
Expand Down
Loading