Skip to content

refactor: workflows - #4315

Merged
EvenSol merged 8 commits into
masterfrom
ref_workflows
Oct 14, 2026
Merged

EvenSol merged 8 commits into
masterfrom
ref_workflows

Conversation

@asmfstatoil

@asmfstatoil asmfstatoil commented Oct 12, 2026 •

Copy link
Copy Markdown
Collaborator

Merged — 2026-10-14

Merged at the maintainer's request as 2d29c197b3bb7039b6cdc5867c68362d55e3b45b from verified head 5a48909ae2c7e73730da975a7a303d5ddd747edf. The branch protection summary requires Run pre-commit checks (PR); its name and successful result were verified before merge. No protection setting was changed.

Follow-on #4328 retains this workflow's eight-shard selector, compatibility checks and report retention. #4320 must carry its bounded dependency-resolution retry into the renamed core workflow. Actual release publication is not established by PR CI.

CI repair — 2026-10-14

Commit 5a48909ae2c7e73730da975a7a303d5ddd747edf repairs shared CI causes while preserving numerical acceptance criteria.

  • Reuse the hermetic evidence-routing fixture from feat(optimization): persist and revalidate field envelope evidence #4312 (d469208a): the previous tests assumed optional enterprise catalogs were installed, causing 27 assertion failures in public CI. Temporary synthetic catalogs exercise real discovery/parsing, plugin-only catalogs, aliases, missing catalogs, duplicate/invalid cues, and invalid evidence statuses.
  • Run the production guard and ledger regression suite in the renamed Devtools workflow.
  • Port fix(network): fail closed on mapped compressor errors #4328's validated eight-shard slow-suite partition. All 102 discovered classes are retained exactly once. The previous four-shard run timed out at 60 minutes; the longest job in the successful eight-shard run was about 27 minutes. These are observed wall times, not a total CPU-work claim.
  • Preserve the four historical slow-test required-check names with compatibility gates that require all eight shards to succeed; unexpected skipped, cancelled, or failed shards cannot pass.
  • Set the Java 21 fast-test matrix to fail-fast: false and retain fast/slow Surefire reports, so one platform's failure does not hide another's diagnostics. Java 8 dependencies remain unchanged.
  • Correct the duplicated .yml suffix in the documentation pre-push filter.

Documentation impact: updated docs/development/BUILD.md, .github/WORKFLOWS.md, and docs/development/TASK_LOG.md with isolation, diagnostics, shard coverage, check-name compatibility, and upstream repair provenance.

Validation on the published tree (Python 3.12 locally; CI uses 3.13):

  • Exact three Devtools workflow test steps: 342 pytest tests passed, 12 skipped, 48 subtests passed; all 3 mesh contract tests passed; report-generator integration checks passed. The 12 skips are environment/optional cases, unchanged by this repair.
  • Focused routing/production/continuous/living suites: 83 passed, 36 subtests passed.
  • Executed the exact shell shard selector with Maven capture: all 102 slow classes assigned once, shard sizes 13,13,13,13,13,13,12,12. Compatibility gate passes only success, rejects failure/cancelled/skipped; YAML parses and the corrected hook matches its workflow path.
  • python3 devtools/run_spotless.py check: exit 0 after the skill's Maven bootstrap.
  • python3 devtools/check_documentation_search.py: exit 0, 788 Markdown + 1 HTML source pages audited.
  • pre-commit run --all-files --hook-stage pre-commit: exit 0.
  • pre-commit run --all-files --hook-stage pre-push: exit 0.
  • git diff --check: exit 0.

All applicable exact-head CI completed successfully, including the full Java 8/21 build matrix. This repair does not change numerical Java code.

- Renamed workflow files for clarity and consistency, updating references in various documentation files.
- Adjusted pre-commit configuration to reflect new workflow names.
- Enhanced AGENTS.md and CONTRIBUTING.md with guidelines on workflow naming conventions.
- Updated README.md and index.md to link to the correct CI build badges.
- Modified devtools scripts to align with new workflow names.
- Revised documentation on task quality gates and NIP issue tracking to reference updated workflows.
- Ensured all references to workflows in the documentation are consistent with the new naming scheme.
@asmfstatoil asmfstatoil changed the title Ref workflows refactor: workflows Oct 13, 2026
asmfstatoil and others added 2 commits October 13, 2026 16:41
- Renamed the publish NeqSim image workflow for clarity.
- Added a new workflow for publishing packages to Maven Central.
- Introduced a workflow for building and pushing the prebuild dev container.
- Updated references in the pre-commit configuration for documentation search coverage.
- Changed CI badge links in the README and index files to reflect updated workflow names.
- Updated documentation to reflect changes in workflow names and paths.
- Fixed references to workflows in various documentation files related to MCP protocol tests.
- Updated the daily research scan workflow name and references in the paper lab tests.
- Adjusted Java test cases to align with new workflow names.
Reuse the hermetic evidence catalog fixture from PR #4312 and the verified eight-shard slow-test partition from PR #4328. Preserve legacy required-check contexts with fail-closed aggregate gates, retain Surefire reports and allow both fast-test platforms to finish.

Include production guard regressions in the renamed Devtools workflow, fix the documentation hook filename filter, and document partitioning, measured runner wall times, and compatibility.
EvenSol added a commit that referenced this pull request Oct 14, 2026
Port the identical hermetic evidence-source fixture from PR #4315 commit 5a48909 (originally repaired in PR #4312). Exercise real agent discovery with synthetic installed and plugin catalogs, including missing and malformed declarations.

Fixes the inherited Devtools CI failure without changing production routing or numerical code. Exact workflow validation: 314 passed, 12 skipped, 48 subtests passed; 3 mesh tests and report integration passed. Spotless, documentation, coverage and both pre-commit stages passed.

Documentation impact: none; only test inputs and isolation change.
@EvenSol
EvenSol merged commit 2d29c19 into master Oct 14, 2026
57 checks passed
@EvenSol
EvenSol deleted the ref_workflows branch October 14, 2026 15:46
EvenSol added a commit that referenced this pull request Oct 14, 2026
Preserve #4315 renamed workflows, eight slow-test shards, historical check contexts and build documentation. Keep #4328 physics and regression source byte-identical and regenerate the combined engineering inventory.

Validation: 125 focused network tests, zero failures/errors, one existing skip; direct Spotless apply/check, documentation search, coverage check, both pre-commit stages and whitespace checks passed. Full exact-head GitHub CI pending.
EvenSol added a commit that referenced this pull request Oct 15, 2026
…ansfer (#4282)

* feat(pipeline): add experimental non-equilibrium film transfer for #4281

* test: isolate evidence routing from optional enterprise catalogs

Port the identical hermetic evidence-source fixture from PR #4315 commit 5a48909 (originally repaired in PR #4312). Exercise real agent discovery with synthetic installed and plugin catalogs, including missing and malformed declarations.

Fixes the inherited Devtools CI failure without changing production routing or numerical code. Exact workflow validation: 314 passed, 12 skipped, 48 subtests passed; 3 mesh tests and report integration passed. Spotless, documentation, coverage and both pre-commit stages passed.

Documentation impact: none; only test inputs and isolation change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants