fix(network): fail closed on mapped compressor errors - #4328

Master integration — 2026-10-15

Integrated head d317c462e488c1761eba5cdea2b847a51699e434 incorporates master aa3b281dc7e7ec20b29ed78eba4f8fb4d780924e; verified tree 68a645ae097db90afff7efc164debda098ee46e3. Preserved both independent task-log additions and regenerated the shared coverage inventory. The mapped-compressor acceptance code and its tests remain unchanged from the reviewed PR.

Validation: 112 tests run: 111 passed, one existing skip, zero failures/errors. Stable direct formatting, both hook stages, documentation search, regenerated coverage/check and whitespace checks passed. Documentation impact: retained the existing implementation guides and task-log entries from both branches; no new API, physics or tolerance change is introduced by this integration. Earlier evidence below applies to its recorded checkpoints. Integration follows the user's explicit instruction to merge in dependency order; new-head hosted CI is tracked separately.

Coordination and merge gates — 2026-10-14

Reviewed published head: 2ba5ed80dba2cc03f4eaa6a75de8b7549e4cf9f0.

The mapped-compressor acceptance correction is published. Four new regressions fail the prior implementation; focused network suites ran 129 tests with one existing skip, and the combined #4326 trial ran 145 tests with one existing skip. Current-head CI is still running eight Java 21 jobs; completed checks pass. No current human approval is recorded.

Require the process owner, an independent network/compressor-domain reviewer and independent maintainer coverage for stricter registration/failure-result contracts. One suitably qualified independent maintainer may cover both domain and public-contract review. This single-subsystem correction does not automatically require an NRC; review compatibility of exceptions and infeasible/NaN outputs explicitly.

Integration: Preferred process lane: corrected #4328 → #4326 → repaired #4312. This is an integration/review preference, not a compile dependency. Preserve current master workflows and regenerate shared coverage after integration.

Problem and correction

A configured compressor chart must remain the model used by a mapped network edge. Earlier code could fall back to simplified physics after an exception, or accept a finite result even when the compressor reported an unsuccessful speed solve.

This PR validates enabled charts before graph mutation and again before evaluation. It accepts chart results only when Compressor.solved() is true and power, outlet pressure and temperature are finite and physically admissible. Rejection reports Compressor-Chart-Infeasible, clears stale thermal state, stores NaN power and returns the existing infeasible hydraulic penalty. Ordinary unmapped compressor behavior is unchanged.

The combined #4326/#4328 reproducer requested 100 bara, achieved 11.647 bara with an unconverged speed solve, yet previously exposed 53.132 kW as accepted network evidence. The correction rejects that result.

Current validation

Head: 2ba5ed80dba2cc03f4eaa6a75de8b7549e4cf9f0
Validated tree: e95dfb95bb4beac7269182584287944d9f7979b6
Parent: e92f6579d2a3af124e9522686c8c5461ea379bc0, including master d28b180969e248837e68b5e982374db69e11a376.

• Four new acceptance regressions fail the previous implementation and pass this correction: unsolved finite result, subsequently disabled chart, NaN power and NaN temperature.
• Focused network suites: 129 tests, zero failures/errors, one existing skip.
• Combined with exact [AI-Assisted] fix(compressor): report consistent speed-solve results and convergence #4326 head 22d62de: 145 tests, 144 passed, one existing skip.
• Spotless apply twice and check, pre-commit/pre-push hooks, documentation search, regenerated engineering coverage and whitespace checks passed.

Remains draft pending current-head CI and independent domain/public-contract review under GOVERNANCE.md. These tests establish software acceptance behavior; they do not qualify OEM maps, operating regions, field accuracy or transient behavior.

Coordination and order

Merge the corrected #4328, then #4326, then #4312 after its resume-validation repair and combined evidence tests. The #4306/#4320 flash work requires a subsequent combined process regression, including compressor forward replay and shared-host power. No independent flash solver or fallback physics is introduced here.

#4228 owns canonical network fidelity; #4148 owns map correction physics; #4312/#4188/#3154 own persistence and evidence revalidation. Keep those responsibilities separate.

Documentation impact

Updated the SURF integration guide, pipeline/network skill, task log and generated engineering coverage to describe rejection of unsolved or invalid chart results.

Refs #4228, #4146, #4147, #4148, #4188, #3154, #2911, #3298, #3153, #2899, #1332, #4322, #4312, #4326.

Coordinated foundation and remaining CI

The shared classic-mixing accumulator correction is now isolated in #4333. Merge that foundation before the coordinated #4328 → #4326 → #4312 sequence; keep the mapped-compressor fail-closed behavior and all original limits. Java 21 qualification has passed on this head. The follow-on Java 8 Ubuntu job 116059245469 failed before test execution while resolving the Surefire extensions API artifact descriptor; its Windows Java 8 sibling is still running. A single-job retry cannot start until that workflow finishes (GitHub rejected the request while it was active). This is pending CI evidence, not a source-test failure or a green-readiness claim.