Repository navigation
fix(cli): resume caught JSON input errors at the next line - #321
Draft
owenshen0907 wants to merge 1 commit into
Draft
owenshen0907 wants to merge 1 commit into
owenshen0907 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After
inputsreturns a JSON syntax error, the decoder stays in its failed state. A query that catches that error cannot read the following valid line. The example in #264 consequently returns only the error length.Allow subsequent explicit
input/inputscalls to discard the remainder of the failed line and resume from the next one, retaining decoder read-ahead. Keep error offsets and line context correct across recovery and bound the retained diagnostic buffer. Ordinary CLI input processing keeps its existing stopping behavior for the failed input.Validation:
go test -race -count=1 ./...go vet ./...,staticcheck -checks all,-ST1000 -tags gojq_debug ./..., build, goimports andgit diff --check3Tested on macOS arm64 with Go 1.26.3. Other OS/toolchain matrix jobs are left to CI.
Fixes #264
Base: 2bef47f