Skip to content

Feature/docker ssl network - #27

Merged
olivhoenen merged 41 commits into
iterorganization:developfrom
Louwrensth:feature/docker-ssl-network
Sep 23, 2026
Merged

olivhoenen merged 41 commits into
iterorganization:developfrom
Louwrensth:feature/docker-ssl-network

Conversation

@Louwrensth

@Louwrensth Louwrensth commented Jul 6, 2026 •

Copy link
Copy Markdown
Contributor

PR Summary

Modular nginx architecture for HTTP/HTTPS and route concerns

Compose-based HTTPS and systemd deployment model

Systemd packaging and lifecycle automation via Make

TLS asset strategy migration and cert-path normalization

  • SHAs: 0f79db5, ab29434
  • Migrates runtime from legacy ssl paths/names to docker/nginx/tls with server.pem/server.key, updating Dockerfile, compose mounts, nginx references, and ignore rules.

Certificate generation toolchain refactor

  • SHAs: b512dc5, ab29434
  • Evolves certificate provisioning from shell-script generation to a deterministic Make-based CA/server certificate workflow with SAN template and install/check targets.

SimDB proxy hardening and payload behavior fixes

  • SHAs: 0ad14d7, 2cbe72d
  • Tightens reverse-proxy behavior for prefixed API routes, forwarded-prefix semantics, and request body sizing to reduce integration errors under larger payloads.

Frontend/runtime compatibility adjustments against backend/API expectations

  • SHAs: 2cbe72d, 0ad14d7
  • Updates dashboard-side defaults and references (API version/data query assumptions/docs links) to stay compatible with evolving SimDB server behavior.

CI/CD release pipeline and ownership metadata updates

  • SHAs: 5715458, dc61e5a, cf1b8ba
  • Renames and expands CI workflow to publish version/latest images and release artifacts, while updating repository ownership metadata.

Documentation consolidation for deployment modes and operations

  • SHAs: 7991af1, 1286eb4, ab29434, 8f75257
  • Expands docs/installation.md into a full operator guide covering local compose mode, systemd mode, HTTPS setup, environment controls, and cross-references from comments.

@Louwrensth
Louwrensth force-pushed the feature/docker-ssl-network branch from fccf89a to 6c81174 Compare July 6, 2026 02:54
@Louwrensth
Louwrensth force-pushed the feature/docker-ssl-network branch from 6c81174 to a5029c1 Compare July 6, 2026 03:19
@Louwrensth

Louwrensth commented Aug 8, 2026 •

Copy link
Copy Markdown
Contributor Author

Update image for systemd

The service is using an env file with several runtime variables, update the SIMDB_DASHBOARD_IMAGE or SIMDB_DASHBOARD_TAG: 

[vandell-adm@io-ls-imas-t01 SimDB-Dashboard]$ sudo vim /etc/simdb-dashboard/simdb-dashboard.env

Note that we only review these lines:

## Used in docker-compose.systemd.yml
#SIMDB_DASHBOARD_TAG=service-0.9.0-68-g8819049
SIMDB_DASHBOARD_IMAGE=ghcr.io/louwrensth/simdb-dashboard:service-0.9.0-88-g81bd9eb

Restart service

Optionally, if the service file was modified (not the case now but still doesn't hurt), reload systemd:

[vandell-adm@io-ls-imas-t01 SimDB-Dashboard]$ sudo systemctl daemon-reload

Restart the systemd service:

[vandell-adm@io-ls-imas-t01 SimDB-Dashboard]$ sudo systemctl restart simdb-dashboard.service

@olivhoenen
olivhoenen marked this pull request as ready for review August 10, 2026 14:45
@Louwrensth
Louwrensth force-pushed the feature/docker-ssl-network branch from bb9be9c to 81bd9eb Compare August 13, 2026 22:22
Comment thread docker-compose.systemd.yml Resolved
Comment thread Makefile Resolved
@olivhoenen
olivhoenen self-requested a review August 14, 2026 16:02
gzip compressed the index-<hash>.js from 5.6 -> 1.7 MB.
caching public, immutable makes the browser not GET it again.

surprisingly, not using gzip_static also voids caching behavior of
browser.
@Louwrensth

Copy link
Copy Markdown
Contributor Author

Wow, bef7350 made a big impact.

Before, browsers were downloading the same 5.6MB .js file again and again (every page!), now they only GET 1.7MB once, and never check again for changes!

The rootCA's public key is more easily distributed in test network.
TLS is a more appropriate name than SSL (dated).
A Makefile can better handle dependency between generated files.
@olivhoenen

olivhoenen commented Sep 4, 2026 •

Copy link
Copy Markdown
Contributor
  • verify that there is no performance toll (when uploading) of using nginx from dashboard docker before reaching to the server

@Louwrensth

Louwrensth commented Sep 4, 2026 •

Copy link
Copy Markdown
Contributor Author
  • TODO : review these (they're huge values)
    fastcgi_read_timeout 1800;
    proxy_read_timeout 1800;
    proxy_pass_request_headers on;
    underscores_in_headers on;
    client_max_body_size 100M;

@Louwrensth
Louwrensth force-pushed the feature/docker-ssl-network branch from 8f75257 to 2419513 Compare September 11, 2026 17:01
Louwrensth and others added 10 commits September 14, 2026 20:20
Assisted-by: Claude/opus-5
Without a checkout, gh can't infer the target repo. GH_REPO overrides auto-detection.
so that non-443 HTTPS ports survive the HTTP→HTTPS redirect.
Rename env var and make it applicable to only the systemd compose overlay to clarify intent and remove confusion with COMPOSE_PROJECT_NAME.
e.g. if unit was not started
install target now only copies server.key/server.pem into tls; rootCA.key/rootCA.pem/CSR/serial are not.
images are pulled, not built.
@Louwrensth
Louwrensth force-pushed the feature/docker-ssl-network branch from 2419513 to 695e49c Compare September 14, 2026 18:21
@Louwrensth

Copy link
Copy Markdown
Contributor Author

Thanks Olivier, I've taken into account, your suggestions from:

@olivhoenen olivhoenen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @Louwrensth, let's merge and finalize the tests in pre-prod.

@olivhoenen
olivhoenen merged commit 04ff6f9 into iterorganization:develop Sep 23, 2026
2 checks passed
@Louwrensth
Louwrensth deleted the feature/docker-ssl-network branch October 23, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants