Repository navigation
Feature/docker ssl network - #27
Merged
olivhoenen merged 41 commits intoSep 23, 2026
Merged
Conversation
Rely on sensible default behavior provided by nginx's docker image.
Louwrensth
force-pushed
the
feature/docker-ssl-network
branch
from
July 6, 2026 02:54
fccf89a to
6c81174
Compare
remove DASHBOARD_PORT from container environment
Louwrensth
force-pushed
the
feature/docker-ssl-network
branch
from
July 6, 2026 03:19
6c81174 to
a5029c1
Compare
and make install targets.
Contributor
Author
Update image for systemdThe service is using an Note that we only review these lines: Restart serviceOptionally, if the service file was modified (not the case now but still doesn't hurt), reload systemd: Restart the systemd service: |
olivhoenen
marked this pull request as ready for review
August 10, 2026 14:45
olivhoenen
requested review from
SimonPinches,
olivhoenen and
prasad-sawantdesai
as code owners
August 10, 2026 14:45
Louwrensth
force-pushed
the
feature/docker-ssl-network
branch
from
August 13, 2026 22:22
bb9be9c to
81bd9eb
Compare
olivhoenen
approved these changes
Aug 14, 2026
olivhoenen
self-requested a review
August 14, 2026 16:02
gzip compressed the index-<hash>.js from 5.6 -> 1.7 MB. caching public, immutable makes the browser not GET it again. surprisingly, not using gzip_static also voids caching behavior of browser.
Contributor
Author
|
Wow, bef7350 made a big impact. Before, browsers were downloading the same 5.6MB |
The rootCA's public key is more easily distributed in test network. TLS is a more appropriate name than SSL (dated). A Makefile can better handle dependency between generated files.
Contributor
|
Contributor
Author
|
Louwrensth
force-pushed
the
feature/docker-ssl-network
branch
from
September 11, 2026 17:01
8f75257 to
2419513
Compare
Assisted-by: Claude/opus-5
Without a checkout, gh can't infer the target repo. GH_REPO overrides auto-detection.
so that non-443 HTTPS ports survive the HTTP→HTTPS redirect.
Rename env var and make it applicable to only the systemd compose overlay to clarify intent and remove confusion with COMPOSE_PROJECT_NAME.
e.g. if unit was not started
install target now only copies server.key/server.pem into tls; rootCA.key/rootCA.pem/CSR/serial are not.
images are pulled, not built.
Louwrensth
force-pushed
the
feature/docker-ssl-network
branch
from
September 14, 2026 18:21
2419513 to
695e49c
Compare
Contributor
Author
|
Thanks Olivier, I've taken into account, your suggestions from: |
olivhoenen
approved these changes
Sep 23, 2026
olivhoenen
left a comment
Contributor
There was a problem hiding this comment.
Thanks for this @Louwrensth, let's merge and finalize the tests in pre-prod.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Modular nginx architecture for HTTP/HTTPS and route concerns
Compose-based HTTPS and systemd deployment model
docker-compose.https.yml,docker-compose.systemd.yml), introduces Makefile switching semantics, and aligns image/tag/container-name behavior for host-managed deployments.Systemd packaging and lifecycle automation via Make
TLS asset strategy migration and cert-path normalization
docker/nginx/tlswithserver.pem/server.key, updating Dockerfile, compose mounts, nginx references, and ignore rules.Certificate generation toolchain refactor
SimDB proxy hardening and payload behavior fixes
Frontend/runtime compatibility adjustments against backend/API expectations
CI/CD release pipeline and ownership metadata updates
Documentation consolidation for deployment modes and operations
docs/installation.mdinto a full operator guide covering local compose mode, systemd mode, HTTPS setup, environment controls, and cross-references from comments.