Repository navigation
Add node selector support for cleanup job - #101
Merged
Merged
Conversation
tommydangerous
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a cleanup-job-specific
nodeSelectorso operators can schedule the cleanup CronJob on labeled nodes independently from the Mage application pods.The new value is optional and the chart continues to omit
spec.jobTemplate.spec.template.spec.nodeSelectorwhen it is unset or empty. Existing installations and values files therefore render the cleanup job as they did before.Why
The chart already exposes a top-level
nodeSelectorfor Mage application pods, but the cleanup CronJob did not render that value or provide its own scheduling configuration. In clusters with dedicated maintenance node pools or node-placement policies, operators could not target the cleanup workload without patching the rendered resource.Configuration
cleanupJob.nodeSelectorapplies only to the cleanup CronJob. The existing top-levelnodeSelectorcontinues to control Mage application pods.Backward compatibility
cleanupJob.nodeSelectordefaults to an empty map.nodeSelectorfield.0.2.17to0.2.18.Implementation
spec.jobTemplate.spec.template.spec.nodeSelector.values.yamland the repository README.Testing
helm lint charts/mageaihelm unittest charts/mageai— 27 tests passed