Repository navigation
Move focus into a message when a screen reader does its primary action - #6020
Merged
Merged
Conversation
Copilot-Session: 77b2ba5a-efa7-4a5e-8a90-963dcdef81be Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…hots - Narrator (click on the active descendant) and NVDA (click inside it) get their own files, as #4041 had; the card is emulated, no live bot. - Snapshot after each focus change, with focusManagement.css painting the focused element. - Drop the plain ENTER steps: focusActivity.focusCard.html, focusAttachment.enterKey.html and part-grouping/keyboard.html cover them. - waitFor + expect instead of pageConditions.became. Co-authored-by: Ahona Salsabil <asalsabil@microsoft.com>
Eugene (OEvgeny)
marked this pull request as ready for review
November 5, 2026 21:09
Eugene (OEvgeny)
requested review from
William Wong (compulim),
Chris Whitten (cwhitten) and
Thomas Durnford (tdurnford)
as code owners
November 5, 2026 21:09
William Wong (compulim)
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixed
Description
#4041 fixed #4020, but the transcript rewrite in #4108 dropped its click handler before either shipped (both in 4.15.0). So no release handles a screen reader's "do primary action" on a message: in Narrator scan mode or NVDA browse mode, "Click to interact." does not move into a card (also #4311). The focused message now handles that click, as #4041 did, and moves focus inside the message or group.
Design
role="application"(Screen reader: support "do primary action" #4041's comment): it turns off browse mode for the whole transcript.Specific Changes
ActivityRow,PartGroupingActivity: on click, focus the focus trap's target, as ENTER doesFocusTrap:targetRefprop for that targetfocusAttachment.screenReaderPrimaryAction.windowsNarrator.html: card active → text box focused → back after ESCAPEfocusAttachment.screenReaderPrimaryAction.nvda.html: same, clicking inside the active descendantpart-grouping/primaryAction.windowsNarrator.html: same for a group and its "Show less" buttonI have added tests and executed them locally
I have added
.changelog/<PR#>-<slug>.mdI have updated documentation
Review Checklist
z-index)package.jsonandpackage-lock.jsonreviewed