Repository navigation
Re-record cassettes for ellmer 0.5.1 compatibility and update deprecated models - #222
Merged
Merged
Conversation
thisisnic
changed the title
thisisnic
marked this pull request as draft
November 6, 2026 12:09
16 of 20 tasks
Collaborator
|
Thank you! Ideally, vitals tests would continue to pass if the vitals functionality isn't broken by ellmer, even if the request format changes slightly due to changes in ellmer. In addition to your changes, I will try and send some changes up shortly s.t. ellmer doesn't need to wait on vitals to release when making changes that could reasonably be interpreted as ellmer internal API. One sec! |
Collaborator
|
Going to merge this as-is and then rework separately! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These showed up as failing when we ran our revdepchecks ahead of the upcoming ellmer release, as we change the body of some API calls.
I re-recorded the cassettes, but some models were showing up as deprecated so I bumped those too in line with the models used by ellmer.
These changes should fail on current CI but pass with ellmer 0.5.0
Fixes #221