Repository navigation
feat(network): qualify field-scale injection topology - #4279
Merged
Merged
Conversation
This was referenced Oct 9, 2026
EvenSol
marked this pull request as ready for review
October 9, 2026 15:08
This was referenced Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Advances #4228 after merged #4276 with the next dependency-ready canonical-topology increment.
FieldNetworkTopologybuilders for chokes, fixed-outlet and differential-pressure pumps, and compressorsLoopedPipeNetworkas the single pressure/flow graph and delegates to its existing equationsNo parallel topology, solver, well model, pump model, compressor model, or hydraulic abstraction is introduced.
Field-scale acceptance evidence
The CO2 fixture deliberately starts at a compressor-discharge boundary. The generic compressor builder is identity/replay-tested, but this PR does not qualify a compressor train, compressor map, dense-phase CO2 compression, pump map, reservoir injectivity, or field-specific operating envelope.
Validation
Validated locally on tree
64d4dd6f835bd5d97b0de5665edbe7389b304588, remote commite46a8d1db09bb9b02c79c4a8051e20e234695965, based directly onmasterffde2f43443ae65d57d02497e31fefb71b637555:--checkgit diff --checkLocal Javadoc could not run because this runner provides a Java 17 JRE but no
javacorjavadocexecutable. Thepre-commitexecutable is also unavailable; the mandatory direct gates above were run. Exact-head hosted CI remains authoritative.VALIDATION PENDING EXACT-HEAD CI — KEEP DRAFT.
Coordination and scope boundary
ProcessAutomation, optimizer logic, or that PR's production implementation; overlap is limited to the SURF guide and generated capability index.Next dependency
Connect this field-scale topology to live multi-template production/injection
WellSystem/WellFlowcases with qualified pump/compressor maps, shared host power/capacity, controlled reservoir pressure, and branch/loop outage and brownfield-impact scenarios coordinated with #4275/#4188/#3154. Then map the same geometry/equipment intoSubseaProductionSystemSURF design/cost and optimization.Five-of-ten exact-head coordination — 2026-10-09
Exact head
e46a8d1db09bb9b02c79c4a8051e20e234695965remains open, draft, mergeable, review-free, and thread-free. Eight auxiliary workflow groups pass; Build/Test/Javadoc has 13/14 successful jobs with Java 8 Windows active. Keep draft pending completion of the exact-head matrix and independent engineering/domain review.Current
masterisea7d61ac1cbfc4b25689a4e81406a7bef248ae64after merged #4272. Positively identified autonomous implementation occupancy is 5/10: #4274, #4275, #4277, #4279, and #4280. Ten remains both target and absolute global ceiling.Package 3 for #3153 remains unaccepted and unstarted because #4275, #4277, #4279, and #4280 own
src/main/resources/neqsim/mcp/engineering-coverage.json; this PR and #4275 also overlap in the SURF guide. No campaign source mutation, workflow retry, rebase, synchronization, force-push, replacement, closure, merge, readiness transition, or peer-head mutation was performed.Single failed-job retry — 2026-10-09
The initial Java 8 Windows job completed with one failure in
FieldToFacilityOptimizationAcceptanceTest.evaluatesReversibleMultiWellFieldToFacilityEnvelope: a fail-closed optimizer constraint verdict after the candidate values and reverse-order restoration matched exactly and the baseline reconverged. This PR does not change that optimizer test,ProcessAutomation, or the field-to-facility acceptance implementation; the other 13 jobs passed.A single failed-job-only retry was requested for workflow run
37897335811after re-verifying unchanged exact heade46a8d1db09bb9b02c79c4a8051e20e234695965. The replacement Java 8 Windows job is queued. No source, head, base, branch history, full-workflow rerun, rebase, synchronization, readiness state, or peer PR was changed.Isolated retry completion and portfolio rotation — 2026-10-09
The failed-job-only retry of Java 8 Windows completed successfully on unchanged exact head
e46a8d1db09bb9b02c79c4a8051e20e234695965. All nine workflow groups and the 14/14 build/test/Javadoc matrix now pass. The PR remains open and draft with no reviews or unresolved threads. GitHub reports it non-mergeable against advancedmaster; preserve the exact head and defer integration to maintainers.#4275 merged as current
master8d52025524c0df5f47dae13838648db8025787ec. Positively identified autonomous implementation occupancy remains 5/10: #4274, #4277, #4279, #4280, and #4282. Ten remains both target and absolute global ceiling.Package 3 for #3153 remains unaccepted and unstarted because #4277, #4279, #4280, and #4282 own
src/main/resources/neqsim/mcp/engineering-coverage.json. No source, head, base, branch history, full-workflow rerun, rebase, synchronization, readiness transition, merge, closure, or peer-head mutation was performed.Mergeability recalculation — 2026-10-09
GitHub's final recalculation now reports this unchanged exact head mergeable against current
master8d52025524c0df5f47dae13838648db8025787ec. This supersedes the transient non-mergeable statement above. The PR remains open and draft; no head, base, source, workflow, rebase, synchronization, readiness state, or peer PR changed.